----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3120/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11123:0bd0cfe0a3b8 --------------------------- ruby: TBETable: use ENTRY* instead of ENTRY Required for a later patch on dropping static block size bytes in ruby. We need to provide the TBE with the size of a cache block so that it can allocate a data block of that size. But it is not possible to do so while the TBE is being constructed since SLICC does not allow defining constructors with arguments. So, the function that allocates an entry in the TBETable cannot assign it since that would call on the assignment operator on the DataBlock which will try to copy data from an unallocated data buffer to an unallocated data buffer. We avoid this call to the assignment operator for the DataBlock by using ENTRY* in TBETable. Diffs ----- src/mem/ruby/structures/TBETable.hh 5a2e1b1b5c43 Diff: http://reviews.gem5.org/r/3120/diff/ Testing ------- Thanks, Nilay Vaish _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
