changeset d2114f5629ff in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=d2114f5629ff
description:
ruby: RubyPort delete snoop requests
In RubyPort::ruby_eviction_callback, prior changes fixed a memory leak
caused
by instantiating separate packets for each port that the eviction was
forwarded
to. That change, however, left the instantiated request to also leak.
Allocate
it on the stack to avoid the leak.
diffstat:
src/mem/ruby/system/RubyPort.cc | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diffs (22 lines):
diff -r c5ac64b4b020 -r d2114f5629ff src/mem/ruby/system/RubyPort.cc
--- a/src/mem/ruby/system/RubyPort.cc Tue Sep 29 09:28:25 2015 -0500
+++ b/src/mem/ruby/system/RubyPort.cc Tue Sep 29 09:28:25 2015 -0500
@@ -505,13 +505,14 @@
RubyPort::ruby_eviction_callback(Addr address)
{
DPRINTF(RubyPort, "Sending invalidations.\n");
- // This request is deleted in the stack-allocated packet destructor
- // when this function exits
+ // Allocate the invalidate request and packet on the stack, as it is
+ // assumed they will not be modified or deleted by receivers.
// TODO: should this really be using funcMasterId?
- RequestPtr req = new Request(address, 0, 0, Request::funcMasterId);
+ Request request(address, RubySystem::getBlockSizeBytes(), 0,
+ Request::funcMasterId);
// Use a single packet to signal all snooping ports of the invalidation.
// This assumes that snooping ports do NOT modify the packet/request
- Packet pkt(req, MemCmd::InvalidateReq);
+ Packet pkt(&request, MemCmd::InvalidateReq);
for (CpuPortIter p = slave_ports.begin(); p != slave_ports.end(); ++p) {
// check if the connected master port is snooping
if ((*p)->isSnooping()) {
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
