----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2993/#review7381 -----------------------------------------------------------
Ship it! Overall the patch seems fine to me, just one small change. src/mem/serial_link.cc (line 64) <http://reviews.gem5.org/r/2993/#comment6232> const ref - Nilay Vaish On Oct. 15, 2015, 7:11 a.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2993/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 7:11 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11175:e9147782d0c8 > --------------------------- > mem: Serial Link model for the HMC > > This changeset adds a serial link model for the Hybrid Memory Cube (HMC). > SerialLink is a simple variation of the Bridge class, with the ability to > account for the latency of packet serialization. Also trySendTiming has been > modified to correctly model bandwidth. > > > Diffs > ----- > > src/mem/serial_link.cc PRE-CREATION > src/mem/SConscript 3a4d1b5cd05c > src/mem/SerialLink.py PRE-CREATION > src/mem/serial_link.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/2993/diff/ > > > Testing > ------- > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
