> On Oct. 14, 2015, 2:02 a.m., Nilay Vaish wrote: > > Format this patch again. Read the following page: > > http://gem5.org/Submitting_Contributions
There are several lines are more than 80 characters. Also make sure that the identation is correct. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2993/#review7371 ----------------------------------------------------------- On Oct. 14, 2015, 12:55 p.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2993/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 12:55 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11174:70ef458b03b6 > --------------------------- > This changeset adds a serial link model for the Hybrid Memory Cube (HMC). > SerialLink is a simple variation of the Bridge class, with the ability to > account for the latency of packet serialization. Also trySendTiming has been > modified to correctly model bandwidth. > This patch should be applied along with thw following changeset to model a > complete memory cube: > http://reviews.gem5.org/r/2986/ > > > Diffs > ----- > > src/mem/SConscript 9261e98e4501 > src/mem/SerialLink.py PRE-CREATION > src/mem/serial_link.hh PRE-CREATION > src/mem/serial_link.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2993/diff/ > > > Testing > ------- > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
