----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3065/#review7384 -----------------------------------------------------------
Seems fine overall. src/arch/x86/isa/insts/simd128/floating_point/data_transfer/move.py (line 84) <http://reviews.gem5.org/r/3065/#comment6238> Is there a reason to use disp instead of DISPLACEMENT? As far as I can tell, it should not matter, which makes me wonder why we have three different names: disp, DISPLACMENT and adjustedDisp. I think all of them translate to the displacement field in the instruction. - Nilay Vaish On Oct. 7, 2015, 3 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3065/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 3 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11059:fc3d1684cbd1 > --------------------------- > x86: implement movntps/movntpd SSE insts > > These are non-temporal packed SSE stores. For now, we are not > supporting the cache hints, but are implementing them the same > as the non-hinting movaps/movapd instructions. > > Also got rid of the placeholder file that was intended for these insts > (simd128/floating_point/data_transfer/move_non_temporal.py) since it > seemed more logical to put them in with the other moves. > > > Diffs > ----- > > src/arch/x86/SConscript 842f56345a421244a7a8988a5bc4fb1cfbf409ef > src/arch/x86/isa/decoder/two_byte_opcodes.isa > 842f56345a421244a7a8988a5bc4fb1cfbf409ef > src/arch/x86/isa/insts/simd128/floating_point/data_transfer/__init__.py > 842f56345a421244a7a8988a5bc4fb1cfbf409ef > src/arch/x86/isa/insts/simd128/floating_point/data_transfer/move.py > 842f56345a421244a7a8988a5bc4fb1cfbf409ef > > src/arch/x86/isa/insts/simd128/floating_point/data_transfer/move_non_temporal.py > 842f56345a421244a7a8988a5bc4fb1cfbf409ef > > Diff: http://reviews.gem5.org/r/3065/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
