----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3131/#review7383 -----------------------------------------------------------
src/base/loader/object_file.cc (lines 127 - 153) <http://reviews.gem5.org/r/3131/#comment6237> I suggest we heave this off to separate function. src/base/loader/object_file.cc (line 130) <http://reviews.gem5.org/r/3131/#comment6234> nullptr src/base/loader/object_file.cc (line 150) <http://reviews.gem5.org/r/3131/#comment6236> nullptr src/base/loader/object_file.cc (lines 154 - 156) <http://reviews.gem5.org/r/3131/#comment6235> Make these lines common to both if and else. - Nilay Vaish On Sept. 21, 2015, 11:42 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3131/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 11:42 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Automatically detect and decompress gzip'd content in the object loader. > > > Diffs > ----- > > src/base/loader/object_file.cc 3be6083fd7744db6f9c6a6295f52331f09b3c5e4 > > Diff: http://reviews.gem5.org/r/3131/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
