----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3191/#review7447 -----------------------------------------------------------
Ship it! I'm fine with this. It would be nice to have a readme or a gem5 wiki entry containing (1) what this runtime can do, and (2) abstractly, how it works in the simulator (e.g. compiling it into benchmark binaries, which modes it works in SE/FS(?), and which ISAs it's known to work with since I expect there may be address/type sizing constraints). ext/cl-runtime/cl_runtime.cc (line 1529) <http://reviews.gem5.org/r/3191/#comment6288> Out of curiosity... Does this mean the runtime operates just on unified virtual memory? Or is there more to this (e.g. a driver)? - Joel Hestness On Oct. 30, 2015, 9:52 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3191/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 9:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11197:b2b56ddfcd39 > --------------------------- > ext: add a simple emulated cl-runtime for the gpu > > > Diffs > ----- > > ext/cl-runtime/cl_runtime.cc PRE-CREATION > ext/cl-runtime/lib.mk PRE-CREATION > ext/cl-runtime/cl_event.h PRE-CREATION > ext/cl-runtime/cl_runtime.hh PRE-CREATION > ext/cl-runtime/CL/cl_ext.h PRE-CREATION > ext/cl-runtime/CL/cl_gl.h PRE-CREATION > ext/cl-runtime/CL/cl_gl_ext.h PRE-CREATION > ext/cl-runtime/CL/cl_platform.h PRE-CREATION > ext/cl-runtime/CL/opencl.h PRE-CREATION > ext/cl-runtime/Makefile PRE-CREATION > ext/cl-runtime/SConscript PRE-CREATION > ext/cl-runtime/cl_command_queue.h PRE-CREATION > SConstruct 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > ext/cl-runtime/CL/cl.h PRE-CREATION > ext/cl-runtime/CL/cl.hpp PRE-CREATION > > Diff: http://reviews.gem5.org/r/3191/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
