----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3191/#review7590 -----------------------------------------------------------
Since this is living in the ext/ directory, I assume there is an upstream repository where this originated from. Could you add a link to that in the commit message and preferably also the revision it is based on? If I'm not mistaken, the resason this is in ext/ is because the GPU simulator needs access to the CL headers, but not the CL runtime itself. Is this correct? Also, is this the runtime (which seems to be compiled using separate Makefiles) used by the simulated guest CL code? If so, would it make sense to keep the CL headers and the runtime in separate ext directories (the former presumably have a different license and are owned by Khronos) and keep the runtime somewhere else (maybe not even in the main distro)? We currently link gem5 with the libraries in ext/ and this seems like the only library that is intended for the guest system. - Andreas Sandberg On Oct. 30, 2015, 9:52 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3191/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 9:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11197:b2b56ddfcd39 > --------------------------- > ext: add a simple emulated cl-runtime for the gpu > > > Diffs > ----- > > ext/cl-runtime/cl_runtime.cc PRE-CREATION > ext/cl-runtime/lib.mk PRE-CREATION > ext/cl-runtime/cl_event.h PRE-CREATION > ext/cl-runtime/cl_runtime.hh PRE-CREATION > ext/cl-runtime/CL/cl_ext.h PRE-CREATION > ext/cl-runtime/CL/cl_gl.h PRE-CREATION > ext/cl-runtime/CL/cl_gl_ext.h PRE-CREATION > ext/cl-runtime/CL/cl_platform.h PRE-CREATION > ext/cl-runtime/CL/opencl.h PRE-CREATION > ext/cl-runtime/Makefile PRE-CREATION > ext/cl-runtime/SConscript PRE-CREATION > ext/cl-runtime/cl_command_queue.h PRE-CREATION > SConstruct 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > ext/cl-runtime/CL/cl.h PRE-CREATION > ext/cl-runtime/CL/cl.hpp PRE-CREATION > > Diff: http://reviews.gem5.org/r/3191/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
