----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/#review7563 -----------------------------------------------------------
src/base/types.hh (line 203) <http://reviews.gem5.org/r/3205/#comment6499> Joel's comment from 3185: I'm a little confused about the need for this. Is it not possible to just set a function pointer in Requests? Why do we need to dynamically instantiate and delete a wrapper class for the function pointer in each atomic Request? src/mem/protocol/RubySlicc_Exports.sm (line 156) <http://reviews.gem5.org/r/3205/#comment6500> Joel's comment from 3185: Why have separate GPU atomic types? I don't see where there are used in other patches. src/mem/request.hh (line 162) <http://reviews.gem5.org/r/3205/#comment6501> Joel's comment from 3185: This flag doesn't appear to be used anywhere... - Tony Gutierrez On Nov. 12, 2015, 2:05 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3205/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 2:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11192:285588f39602 > --------------------------- > mem: support for gpu-style RMWs in ruby > > This patch adds support for GPU-style read-modify-write (RMW) operations in > ruby. Such atomic operations are traditionally executed at the memory > controller > (instead of through an L1 cache using cache-line locking). > > Currently, this patch works by propogating operation functors through the > memory > system. > > > Diffs > ----- > > src/base/types.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/abstract_mem.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/packet.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/protocol/RubySlicc_Exports.sm > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/request.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3205/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
