> On Nov. 2, 2015, 8:45 p.m., Joel Hestness wrote: > > Please give this a real description. Why do we need to remove this > > functionality? > > Sooraj Puthoor wrote: > This patch is the same as patch 2550 (reviews.gem5.org/r/2550/). So, > would it help if we use the same description used in that patch for this > patch also? According to patch 2550, this functionality was removed becasue > it is unnecessary to have this functionality. > > Sooraj Puthoor wrote: > Will update patch description in the next revision of this patch
Most likely (unless you come up with an alternative) you will have to drop this patch since MOESI Hammer uses the multiple machines types in single declaration functionality. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3176/#review7443 ----------------------------------------------------------- On Oct. 30, 2015, 9:49 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3176/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 9:49 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11182:2b48ac25cf2f > --------------------------- > ruby: imported from reviewboard patch 2550 > > filename temp_nilay_rm_multi_machtypes.patch > > > Diffs > ----- > > src/mem/slicc/ast/MachineAST.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/slicc/parser.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3176/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
