> On Nov. 2, 2015, 12:45 p.m., Joel Hestness wrote: > > Please give this a real description. Why do we need to remove this > > functionality? > > Sooraj Puthoor wrote: > This patch is the same as patch 2550 (reviews.gem5.org/r/2550/). So, > would it help if we use the same description used in that patch for this > patch also? According to patch 2550, this functionality was removed becasue > it is unnecessary to have this functionality. > > Sooraj Puthoor wrote: > Will update patch description in the next revision of this patch > > Nilay Vaish wrote: > Most likely (unless you come up with an alternative) you will have to > drop this patch since MOESI Hammer uses the multiple machines types in single > declaration functionality.
That usage is not necessary. The patch has been updated to remove multi types from MOESI_hammer-cache.sm. All regressions pass. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3176/#review7443 ----------------------------------------------------------- On Dec. 24, 2015, 12:03 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3176/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2015, 12:03 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11275:35850e75c5f1 > --------------------------- > ruby: slicc: remove support for single machine, multiple types > > This patch is imported from reviewboard patch 2550 by Nilay. > It was possible to specify multiple machine types with a single state machine. > This seems unnecessary and is being removed. > > > Diffs > ----- > > src/mem/protocol/MOESI_hammer-cache.sm > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/slicc/ast/MachineAST.py d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/slicc/parser.py d9a0136ab8cc4b3cf4821d064140b857e60db0dd > > Diff: http://reviews.gem5.org/r/3176/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
