> On Oct. 16, 2015, 3:15 p.m., Nilay Vaish wrote: > > util/systemc/stats.cc, line 79 > > <http://reviews.gem5.org/r/3132/diff/3/?file=50335#file50335line79> > > > > The file name can be kept as constant, but at least pass an argument to > > this function that specifies the file path. > > I would prefer if you use the same output directory that the rest of > > the system is using. > > Abdul Mutaal Ahmad wrote: > are you suggesting to use OutputDirectory class and get the current > directory create a stats file there. As far as I know the current management > of stats is wrapped inside the python calls
Forget about using the OutputDirectory class for the time being. Is it at all possible for statsDump to receive a file path in which statistics are going to be dumped? I would not assume that m5out directory is present in cwd. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3132/#review7382 ----------------------------------------------------------- On Oct. 16, 2015, 1:46 p.m., Abdul Mutaal Ahmad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3132/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 1:46 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > In previous versions of systemC-gem5 coupling statistics were not updated for > the systemc-gem5 simulation. systemC-gem5 simulation only need the previously > built config.ini file and normal gem5 simulation has to be run once to > generate config.ini file. Thus stats.txt inside the m5out folder is redundant > for systemC-gem5 simulation. A new stats file is now generated with the all > the statistics for systemC-gem5 simulation. This will also resolve the stats > issue in tlm-sysmtemC simulation. > > > Diffs > ----- > > util/systemc/stats.hh UNKNOWN > util/systemc/stats.cc UNKNOWN > util/tlm/main.cc UNKNOWN > util/systemc/main.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/3132/diff/ > > > Testing > ------- > > > Thanks, > > Abdul Mutaal Ahmad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
