> On Nov. 16, 2015, 1:38 p.m., Andreas Hansson wrote:
> > It is not clear to me why this is not just calling the "normal" stats dump.
> > It seems like an unfortunate amount of code duplication.
>
> Abdul Mutaal Ahmad wrote:
> It is using the same API as used in util/cxx_config. Even the
> util/systemc is built on the same code. Since systemC runs need 2 parts,
> first to generate the config.ini and then run it within systemC. The only
> thing which seems logical is to use same stats.txt which was used in the
> first part to generate config.ini. The "normal" stats are calculated through
> python calls.
The two examples should be developed to share a C++ mechanism for dumping stats
which should probably then be pushed back into the normal codebase (out of
util/...). I haven't been following developments in stats and so can't really
comment on how much Python is still required by them. Both
util/cxx_config/stats.{cc,hh} and util/systemc/stats.{cc,hh} were offered as
proof-of-principle examples.
I think the presence of the C++ stats dumping code in this patch takes the
discussion one step on by offering a usable implementation. It may be that C++
and Python-involving stats can't converge but this patch at least provides a
route for Python-less gem5 users to make use of stats in the same form. I think
the code offered here still represents a significant improvement on the
original util/{cxx_config,systemc}/stats.{cpp,h}. (Full disclosure: I've not
read the cascading dynamic_cast in any detail nor tried running it)
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3132/#review7598
-----------------------------------------------------------
On May 30, 2016, 9:37 a.m., Abdul Mutaal Ahmad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3132/
> -----------------------------------------------------------
>
> (Updated May 30, 2016, 9:37 a.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> In previous versions of systemC-gem5 coupling statistics were not updated for
> the systemc-gem5 simulation. systemC-gem5 simulation only need the previously
> built config.ini file and normal gem5 simulation has to be run once to
> generate config.ini file. Thus stats.txt inside the m5out folder is redundant
> for systemC-gem5 simulation. A new stats file is now generated with the all
> the statistics for systemC-gem5 simulation. This will also resolve the stats
> issue in tlm-sysmtemC simulation.
>
>
> Diffs
> -----
>
> util/systemc/main.cc UNKNOWN
> util/systemc/stats.hh UNKNOWN
> util/systemc/stats.cc UNKNOWN
> util/tlm/main.cc UNKNOWN
>
> Diff: http://reviews.gem5.org/r/3132/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abdul Mutaal Ahmad
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
