----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3251/#review7731 -----------------------------------------------------------
Ship it! Ship It! - Tony Gutierrez On Dec. 9, 2015, 3:51 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3251/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 3:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11259:8d9c05513c3c > --------------------------- > mem: Do not use sender state to track forwarded snoops in cache > > This patch changes how the cache tracks which snoops are forwarded, > and which ones are created locally. Previously the identification was > based on an empty sender state of a specific class, but this method > fails to distinguish which cache actually attached the sender > state. Instead we use the same mechanism as the crossbar, and keep > track of the requests that have outstanding snoops. > > > Diffs > ----- > > src/mem/cache/cache.hh 8ed230a0b28c > src/mem/cache/cache.cc 8ed230a0b28c > > Diff: http://reviews.gem5.org/r/3251/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
