> On Dec. 24, 2015, 12:23 a.m., Steve Reinhardt wrote: > > Doesn't the current mechanism work because a new ForwardResponseRecord > > would be created at each level of forwarding, and then peeled off at each > > level of response? Not saying this is robust, just curious if there's an > > actual bug here or just a concern. > > > > Another alternative would be to add a cache pointer to > > ForwardResponseRecord, then the receiver can check/verify that the > > contained pointer points to 'this' before proceeding.
There should not be a correctness issue here, merely a clunky mechanism replaced with a more intuitive one imho. > On Dec. 24, 2015, 12:23 a.m., Steve Reinhardt wrote: > > src/mem/cache/cache.cc, line 2382 > > <http://reviews.gem5.org/r/3251/diff/1/?file=52203#file52203line2382> > > > > how does this change relate to snoop forwarding? My bad. I'll move this fix to a separate patch. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3251/#review7742 ----------------------------------------------------------- On Dec. 9, 2015, 11:51 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3251/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 11:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11259:8d9c05513c3c > --------------------------- > mem: Do not use sender state to track forwarded snoops in cache > > This patch changes how the cache tracks which snoops are forwarded, > and which ones are created locally. Previously the identification was > based on an empty sender state of a specific class, but this method > fails to distinguish which cache actually attached the sender > state. Instead we use the same mechanism as the crossbar, and keep > track of the requests that have outstanding snoops. > > > Diffs > ----- > > src/mem/cache/cache.hh 8ed230a0b28c > src/mem/cache/cache.cc 8ed230a0b28c > > Diff: http://reviews.gem5.org/r/3251/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
