> On Dec. 24, 2015, 12:09 a.m., Steve Reinhardt wrote: > > src/mem/cache/mshr.cc, line 123 > > <http://reviews.gem5.org/r/3259/diff/1/?file=52247#file52247line123> > > > > seems complicated to have to track these transitions to know when to > > call pkt->allocate() and when not to...
This is the only place where we actually change the command for an existing packet. We could make the cmd field const and rather create new packets, but that seems a bit overkill. > On Dec. 24, 2015, 12:09 a.m., Steve Reinhardt wrote: > > src/mem/cache/cache.cc, line 2060 > > <http://reviews.gem5.org/r/3259/diff/1/?file=52246#file52246line2060> > > > > is there a case where we reach this code w/o pkt->hasData() being true? > > given that 'respond' is only set if we have a modified copy, it seems > > unlikely... again, if not, perhaps an assert is more apporpriate? Yes there is. Upgrades in particular. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3259/#review7741 ----------------------------------------------------------- On Dec. 16, 2015, 12:40 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3259/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 12:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11281:e01a026a48ad > --------------------------- > mem: Do not allocate space for packet data if not needed > > This patch looks at the request and response command to determine if > either actually has any data payload, and if not, we do not allocate > any space for packet data. > > The only tricky case is where the command type is changed as part of > the MSHR functionality. In these cases where the original packet had > no data, but the new packet does, we need to explicitly call > allocate(). > > > Diffs > ----- > > src/mem/cache/cache.cc a3b41de1c4f1 > src/mem/cache/mshr.cc a3b41de1c4f1 > src/mem/packet.hh a3b41de1c4f1 > > Diff: http://reviews.gem5.org/r/3259/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
