----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3259/#review7788 -----------------------------------------------------------
src/mem/cache/mshr.cc (line 125) <http://reviews.gem5.org/r/3259/#comment6756> this comment is no longer needed src/mem/cache/mshr.cc (line 132) <http://reviews.gem5.org/r/3259/#comment6757> is it worth checking pkt->hasData()? as I said before, I don't see how you could start off with a non-data request and convert it to one that has data, since there's no way to actually set that data field to anything meaningful here. How about: if (!has_data) { assert(!pkt->hasData()); if (pkt->hasRespData()) { pkt->allocate(); } } - Steve Reinhardt On Dec. 29, 2015, 8:43 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3259/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 8:43 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11283:cabe32e23f17 > --------------------------- > mem: Do not allocate space for packet data if not needed > > This patch looks at the request and response command to determine if > either actually has any data payload, and if not, we do not allocate > any space for packet data. > > The only tricky case is where the command type is changed as part of > the MSHR functionality. In these cases where the original packet had > no data, but the new packet does, we need to explicitly call > allocate(). > > > Diffs > ----- > > src/mem/cache/cache.cc 3fd1142adad9 > src/mem/cache/mshr.cc 3fd1142adad9 > src/mem/packet.hh 3fd1142adad9 > > Diff: http://reviews.gem5.org/r/3259/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
