----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3275/#review7922 -----------------------------------------------------------
I am not massively thrilled, but our current config system definitely has some challenges. The biggest issue here is that the options only apply to a very specific instance of the memory controller, and I see how users may get confused. If you want to go down this route we should at least check and warn if the values are not used. Also, how does it interact with a multi-channel memory? Lastly, the existing memory command-line options are "mem" and not "memory". - Andreas Hansson On Jan. 14, 2016, 12:01 a.m., Matthew Poremba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3275/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 12:01 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11296:d04dae0d7ec3 > --------------------------- > mem: Expose memory bandwidth and latency for SimpleMemory > > Expose SimpleMemory bandwidth and latency parameters to the command line. > This allows for easier simulation of fixed latency memory controllers to > facilitate simple limit-study investigations. > > > Diffs > ----- > > configs/common/MemConfig.py 14029d75688d71c76e42243456fbce3332b36182 > configs/common/Options.py 14029d75688d71c76e42243456fbce3332b36182 > configs/ruby/Ruby.py 14029d75688d71c76e42243456fbce3332b36182 > > Diff: http://reviews.gem5.org/r/3275/diff/ > > > Testing > ------- > > > Thanks, > > Matthew Poremba > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
