> On Jan. 17, 2016, 11:29 p.m., Andreas Hansson wrote: > > I am not massively thrilled, but our current config system definitely has > > some challenges. The biggest issue here is that the options only apply to a > > very specific instance of the memory controller, and I see how users may > > get confused. If you want to go down this route we should at least check > > and warn if the values are not used. Also, how does it interact with a > > multi-channel memory? Lastly, the existing memory command-line options are > > "mem" and not "memory".
I added the warns as you suggested and i'm willing to go with an even more verbose option name if necessary (e.g., --simple-mem-latency/bandwidth). For multiple memory channels, each channel will use the same parameter values specified by these options. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3275/#review7922 ----------------------------------------------------------- On Jan. 21, 2016, 11:56 p.m., Matthew Poremba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3275/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 11:56 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11310:df69dd6ec6fc > --------------------------- > mem: Expose memory bandwidth and latency for SimpleMemory > > Expose SimpleMemory bandwidth and latency parameters to the command line. > This allows for easier simulation of fixed latency memory controllers to > facilitate simple limit-study investigations. > > > Diffs > ----- > > configs/common/MemConfig.py 9be8a40026dfa419c3daf572407f9391ad48e1ed > configs/common/Options.py 9be8a40026dfa419c3daf572407f9391ad48e1ed > configs/ruby/Ruby.py 9be8a40026dfa419c3daf572407f9391ad48e1ed > > Diff: http://reviews.gem5.org/r/3275/diff/ > > > Testing > ------- > > > Thanks, > > Matthew Poremba > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
