Hi Steve, Thanks for looking into this and raising the issue! I too have wondered about style issues creeping in recently.
For a little while now, I've been looking at hg blame when I see style violations. From what I can tell, most Ruby memory system style issues have been around for a long time, even through file renames and heavy refactoring. That said, I have noted plenty of style issues in Ruby-related review requests in the last 3-6 months, but I haven't followed up to verify that those issues were resolved before the code was pushed. It's possible that some of these have made their way into mainline. > - There's also a bunch of code at the bottom of style.py to allow you to > run it directly as a python script (and not just as a mercurial plug-in). > However, as far I can tell, most if not all of that code is broken. Is > there really a need to maintain this? I can see where it would be nice, so > I'd definitely keep it if it worked, but at this point I'd rather just > delete it than have to fix it. > For this specific prompt, one of my major complaints about the style script is that it's difficult to figure out how to run it stand-alone, and I've felt that the code to allow running it from a python script obfuscates how it is generally used. I'll vote for removing that extra code, and clarifying how to run it. Joel -- Joel Hestness PhD Candidate, Computer Architecture Dept. of Computer Science, University of Wisconsin - Madison http://pages.cs.wisc.edu/~hestness/ _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
