Hi Steve, On 26/01/2016, 22:44, "gem5-dev on behalf of Steve Reinhardt" <[email protected]<mailto:[email protected]> on behalf of [email protected]<mailto:[email protected]>> wrote:
- There's currently an 'hg m5format' command in addition to the 'hg m5style' command. Is there any point in maintaining both of these? Strangely enough they are independent functions. Prior to my patch, only m5format checked spaces after if/for/while. After my patch, I think the only thing that m5format checks that m5style doesn't is line length. Unless there's a reason to keep it, I'd like to get rid of m5format. Merging them sounds like a reasonable approach to me. The only practical reason for keeping them separate is that the style checker (m5style) generally corrects style issues, while m5format only lists formatting violations. I'm not sure if that makes any difference for most use cases though. - There's also a bunch of code at the bottom of style.py to allow you to run it directly as a python script (and not just as a mercurial plug-in). However, as far I can tell, most if not all of that code is broken. Is there really a need to maintain this? I can see where it would be nice, so I'd definitely keep it if it worked, but at this point I'd rather just delete it than have to fix it. I would very much like to keep this functionality and possibly even extend it a bit. We are planning a switch to git internally, so this would be required if we are going to be able to run the style checker. Regards, Andreas IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
