> On Jan. 27, 2016, 1:14 a.m., Steve Reinhardt wrote: > > src/dev/net/etherswitch.cc, line 156 > > <http://reviews.gem5.org/r/3230/diff/5/?file=53403#file53403line156> > > > > do we end up charging the delay twice, since we already accounted for > > it in enqueue()? The delay for the outgoing link should be calculated by > > the link itself, right?
We are not adding delay twice. What we have in enqueue() is scheduling txEvent for the items which are inserted into the queue while there is no other item inside (interface was idle before inserting the item); It directly translates into not having txEvent scheduled. If txEvent is scheduled, then inside transmit() we check for any item left inside the queue and schedule txEvent again to transmit them. > On Jan. 27, 2016, 1:14 a.m., Steve Reinhardt wrote: > > src/dev/net/etherswitch.cc, line 206 > > <http://reviews.gem5.org/r/3230/diff/5/?file=53403#file53403line206> > > > > could use std::make_pair to simplify this a bit Fixed - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/#review7955 ----------------------------------------------------------- On Jan. 24, 2016, 8:35 p.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3230/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 8:35 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11292:9ed37b34da3a > --------------------------- > dist,dev: add an ethernet switch model > > > Diffs > ----- > > src/dev/net/Ethernet.py 9d2364203316 > src/dev/net/SConscript 9d2364203316 > src/dev/net/etherswitch.hh PRE-CREATION > src/dev/net/etherswitch.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3230/diff/ > > > Testing > ------- > > several testing done with different benchmarks and different switch sizes > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
