> On Feb. 23, 2016, 8:23 a.m., Andreas Hansson wrote: > > It would be good if someone could run this with ubsan and asan. > > > > Also, if we all agree that 'gpu-compute' is indeed the most sensible > > keyword we should add it to the list. Something shorted and snappier would > > be nice, but I guess gpgpu, apu are not favoured? > > Marc Orr wrote: > Thanks for suggesting to run the santizers, though I'll assume that's not > required to check this in :-). > > Concerning 'gpu-compute,' I simply followed the wiki: > http://www.gem5.org/Submitting_Contributions > > > "The keyword should be one or more of the following separated by commas: > base, ext, stats, sim, syscall_emul, config, ruby, mem, cpu, gpu-compute, > dev, energy, arch, arm, x86, alpha, mips, power, sparc, kvm, scons, tests, > misc, style."
So it is in the list. Good. I am merely suggesting to run the sanitizers to catch any other issues instead of fixing them one by one. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3337/#review8022 ----------------------------------------------------------- On Feb. 25, 2016, 9:26 p.m., Marc Orr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3337/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 9:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11348:d879687daa1c > --------------------------- > gpu-compute: fix uninitialized value error. > > I came across this uninitialized value error, while running the gpu-compute > model inside valgrind. > > > Diffs > ----- > > src/arch/hsail/insts/mem_impl.hh 64e862d3758f20730c25961e0bbefb1123be4fec > > Diff: http://reviews.gem5.org/r/3337/diff/ > > > Testing > ------- > > > Thanks, > > Marc Orr > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
