> On March 14, 2016, 12:48 a.m., Andreas Hansson wrote: > > util/tlm/sc_port.cc, line 187 > > <http://reviews.gem5.org/r/3313/diff/2/?file=54076#file54076line187> > > > > The transactor should also not see any clean evicts. > > Abdul Mutaal Ahmad wrote: > so I need to drop this line as well > > Andreas Hansson wrote: > I'd suggest to copy&paste the panics from bridge.cc > > Abdul Mutaal Ahmad wrote: > That is the only panic in bridge.cc
My bad. dram_ctrl.cc has an additional check that I think would make sense here as well. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3313/#review8081 ----------------------------------------------------------- On March 14, 2016, 4:25 p.m., Abdul Mutaal Ahmad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3313/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 4:25 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > memInhibitAsserted() has been removed from packet.hh. This change has been > reflected in TLM based SystemC memory > > > Diffs > ----- > > util/tlm/sc_port.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/3313/diff/ > > > Testing > ------- > > > Thanks, > > Abdul Mutaal Ahmad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
