> On Nov. 5, 2015, 3:21 p.m., Nilay Vaish wrote: > > src/arch/x86/bios/IntelMP.py, lines 118-122 > > <http://reviews.gem5.org/r/3194/diff/2/?file=51397#file51397line118> > > > > This is a comment. I don't see how changing it helps. I would rather > > add the "6 byte" comment near the changes made to FSConfig.py. Also > > should we add a check in the corresponding c++ class?
I am indifferent on fixing the comments or removing the quotes around them, or just adding the note about "space padded to 6 bytes". - Bjoern A. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3194/#review7494 ----------------------------------------------------------- On Nov. 4, 2015, 2:51 p.m., Bjoern A. Zeeb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3194/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 2:51 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > According to the Intel Multi Processor Specification rev 1.4 (-006) (*), > section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII > (blank-filled) strings<<. > Properly pad the entries with the missing spaces at the end. > > (*) http://www.intel.com/design/pentium/datashts/24201606.pdf > > > Diffs > ----- > > src/arch/x86/bios/IntelMP.py 2d1d51615e0e > configs/common/FSConfig.py 2d1d51615e0e > > Diff: http://reviews.gem5.org/r/3194/diff/ > > > Testing > ------- > > Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and > "ISA". > > > Thanks, > > Bjoern A. Zeeb > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
