----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3194/#review8198 -----------------------------------------------------------
Ship it! Seems fine to me. The linux kernel I'm using boots correctly with the change. In the future, make sure you use one of the keywords in the first line of the description (The keyword should be one or more of the following separated by commas: base, ext, stats, sim, syscall_emul, config, ruby, mem, cpu, gpu-compute, dev, energy, arch, arm, x86, alpha, mips, power, sparc, kvm, scons, tests, misc, style. From http://gem5.org/Submitting_Contributions#Creating_Patches). I think "config" is probably the right one for this patch. - Jason Lowe-Power On April 13, 2016, 2:23 p.m., Bjoern A. Zeeb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3194/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 2:23 p.m.) > > > Review request for Default, Jason Lowe-Power and Steve Reinhardt. > > > Repository: gem5 > > > Description > ------- > > According to the Intel Multi Processor Specification rev 1.4 (-006) (*), > section 4.3.2 Bus Entries, Bus type strings are >>6-character ASCII > (blank-filled) strings<<. > Properly pad the entries with the missing spaces at the end. > > (*) http://www.intel.com/design/pentium/datashts/24201606.pdf > > > Diffs > ----- > > configs/common/FSConfig.py 9c7b55faea5d > src/arch/x86/bios/IntelMP.py 9c7b55faea5d > > Diff: http://reviews.gem5.org/r/3194/diff/ > > > Testing > ------- > > Booting FreeBSD in FS mode no longer complains about unknown busses "PCI" and > "ISA". > > > Thanks, > > Bjoern A. Zeeb > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
