> On Juni 15, 2016, 2:23 nachm., Andreas Sandberg wrote: > > Thanks for your patch! > > > > I think this config script is independant enough that you should consider > > not using the Options helper in configs/common. I would argue that it just > > creates confusion due to the large number of unused options. I would > > suggest that you make it as independent as possible of the functionality in > > config/common/ and make it completely stand alone instead. However, don't > > consider these comments to be blockers for submission, they are just > > nice-to-have improvements. > > Jason Lowe-Power wrote: > I agree with this, Andreas! What Andreas said is a much clearer way to > get to the point I was making in my review. > > I would really like to see this change. Although I won't block it either, > it seems like it shouldn't take long to update. I hope you choose to, > Matthias.
Thank you for the suggestions, of course I will address them and update the patch! We should get this into gem5 before the SAMOS conference (mid of july) where we will present the new elastic trace player approach and the systemc player. Thanks again and regards Matthias > On Juni 15, 2016, 2:23 nachm., Andreas Sandberg wrote: > > util/tlm/tlm_elastic.py, line 126 > > <http://reviews.gem5.org/r/3477/diff/2/?file=55598#file55598line126> > > > > This shouldn't be needed since you're not in FS mode (and you're > > simulating a trace CPU). Actually cpu.createInterruptController() is needed it wont work else :/ - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3477/#review8408 ----------------------------------------------------------- On Juni 14, 2016, 9:06 nachm., Matthias Jung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3477/ > ----------------------------------------------------------- > > (Updated Juni 14, 2016, 9:06 nachm.) > > > Review request for Default and Andreas Sandberg. > > > Repository: gem5 > > > Description > ------- > > This patch adds an example configuration for elastic trace playing into the > SystemC world, similar to the already existing traffic generator example in > /util/tlm. > > > Diffs > ----- > > util/tlm/README fc247b9c42b6 > util/tlm/tlm_elastic.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3477/diff/ > > > Testing > ------- > > > Thanks, > > Matthias Jung > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
