> On June 22, 2016, 10:42 a.m., Gabor Dozsa wrote: > > src/dev/net/etherpkt.cc, line 55 > > <http://reviews.gem5.org/r/3493/diff/1/?file=55641#file55641line55> > > > > If you serialize the useful data only then you could use dataLength > > here, too. In that case, adding an assertion to make sure dataLength <= > > bufferLength would be good, too.
I removed the bufferLength field. Its only purpose was for serialization, which is no longer necessary after implementing your previous comment. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3493/#review8429 ----------------------------------------------------------- On June 29, 2016, 6:27 p.m., Michael LeBeane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3493/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 6:27 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11549:573a7d349538 > --------------------------- > dev: Redefine 'length' in EthPacketData > Currently, all the network devices create a 16K buffer for the 'data' field > in EthPacketData, and use 'length' to keep track of the size of the packet > in the buffer. This patch introduces 'dataLength' and 'simLength' parameters > to EthPacketData. 'dataLength' stores the amount of space taken up by the > packet in the 'data' buffer. 'simLength' is used to hold the effective length > of the packet used for all timing calulations in the simulator. Serialization > is performed using only the useful data in the packet ('dataLength') and not > necessarily the entire original buffer. > > > Diffs > ----- > > src/dev/net/etherswitch.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/ethertap.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/i8254xGBe.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/ns_gige.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/pktfifo.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/pktfifo.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/sinic.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/tcp_iface.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/etherbus.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/etherdump.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/etherlink.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/etherpkt.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/etherpkt.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/dist_etherlink.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/dist_iface.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/dev/net/dist_packet.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c > > Diff: http://reviews.gem5.org/r/3493/diff/ > > > Testing > ------- > > > Thanks, > > Michael LeBeane > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
