----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3550/#review8503 -----------------------------------------------------------
configs/example/garnet_synth_traffic.py (lines 49 - 58) <http://reviews.gem5.org/r/3550/#comment7378> It would make the command lines slightly more descriptive if this were a "choice" type option. The strings could be converted to ints for the enum on the c++ side. src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc (line 139) <http://reviews.gem5.org/r/3550/#comment7379> Could this be parameterized? There may exist some network where this would need to be increased. src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc (lines 140 - 141) <http://reviews.gem5.org/r/3550/#comment7380> fatal("%s deadlocked at cycle %d", name(), curTick()); could be used directly here. src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc (lines 237 - 238) <http://reviews.gem5.org/r/3550/#comment7381> fatal() can be used directly here - Matthew Poremba On July 13, 2016, 7:02 a.m., Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3550/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 7:02 a.m.) > > > Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and > Matthew Poremba. > > > Repository: gem5 > > > Description > ------- > > garnet: rename networktest to garnet_synthetic_traffic. > networktest is essentially a collection of synthetic traffic patterns > for the network. The protocol name and the tester having the same name > led to multiple python configuration files with the same name, adding > confusion. This patch renames networktest to garnet_synthetic_traffic, > and also adds more traffic patterns such as shuffle, bit-reverse, tornado, > hot-spot, etc. > > > Diffs > ----- > > src/cpu/testers/networktest/networktest.cc cdb94f2332a6 > configs/example/garnet_synth_traffic.py PRE-CREATION > configs/example/ruby_network_test.py cdb94f2332a6 > src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.hh > PRE-CREATION > src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.cc > PRE-CREATION > src/cpu/testers/garnet_synthetic_traffic/GarnetSyntheticTraffic.py > PRE-CREATION > src/cpu/testers/garnet_synthetic_traffic/SConscript PRE-CREATION > src/cpu/testers/networktest/NetworkTest.py cdb94f2332a6 > src/cpu/testers/networktest/SConscript cdb94f2332a6 > src/cpu/testers/networktest/networktest.hh cdb94f2332a6 > > Diff: http://reviews.gem5.org/r/3550/diff/ > > > Testing > ------- > > > Thanks, > > Tushar Krishna > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
