-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3556/#review8507
-----------------------------------------------------------


It seems odd to modify a bunch of garnet "1.0" files when they are deleted in 
the next patch in this series. Did I miss something here? Are these files 
effectively "hg mv" 'd by the next patch?

- Matthew Poremba


On July 13, 2016, 7:03 a.m., Tushar Krishna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3556/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 7:03 a.m.)
> 
> 
> Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and 
> Matthew Poremba.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> topology: add port directions and per-router delay.
> This patch adds port direction names to the links during topology
> creation, which can be used for better printed names for the links
> or for users to code up their own adaptive routing algorithms.
> It also lets every router have an independent latency value to
> support heterogeneous topologies with garnet2.0.
> 
> 
> Diffs
> -----
> 
>   configs/topologies/Mesh_XY.py PRE-CREATION 
>   src/mem/ruby/network/BasicLink.py cdb94f2332a6 
>   src/mem/ruby/network/BasicRouter.hh cdb94f2332a6 
>   src/mem/ruby/network/BasicRouter.cc cdb94f2332a6 
>   src/mem/ruby/network/BasicRouter.py cdb94f2332a6 
>   src/mem/ruby/network/Network.hh cdb94f2332a6 
>   src/mem/ruby/network/Topology.hh cdb94f2332a6 
>   src/mem/ruby/network/Topology.cc cdb94f2332a6 
>   src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh cdb94f2332a6 
>   src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc cdb94f2332a6 
>   src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh cdb94f2332a6 
>   src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc cdb94f2332a6 
>   src/mem/ruby/network/simple/SimpleNetwork.hh cdb94f2332a6 
>   src/mem/ruby/network/simple/SimpleNetwork.cc cdb94f2332a6 
> 
> Diff: http://reviews.gem5.org/r/3556/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tushar Krishna
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to