----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3558/#review8524 -----------------------------------------------------------
All minor stylistic issues. Some white spaces also need to be removed, but weren't marked in this review since they are quite obvious. src/mem/ruby/network/garnet2.0/GarnetNetwork.cc (lines 75 - 76) <http://reviews.gem5.org/r/3558/#comment7406> Opening brace must be on the same line as the control keyword. src/mem/ruby/network/garnet2.0/GarnetNetwork.cc (line 118) <http://reviews.gem5.org/r/3558/#comment7407> Opening brace. src/mem/ruby/network/garnet2.0/GarnetNetwork.cc (lines 123 - 125) <http://reviews.gem5.org/r/3558/#comment7408> 'Else' keywords should follow the closing 'if' brace on the same line. src/mem/ruby/network/garnet2.0/GarnetNetwork.cc (line 131) <http://reviews.gem5.org/r/3558/#comment7409> Add a space after 'if'. Also, a space before brace. src/mem/ruby/network/garnet2.0/InputUnit.cc (line 125) <http://reviews.gem5.org/r/3558/#comment7410> Opening brace. src/mem/ruby/network/garnet2.0/InputUnit.cc (lines 129 - 131) <http://reviews.gem5.org/r/3558/#comment7411> 'else' and braces. src/mem/ruby/network/garnet2.0/NetworkInterface.cc (lines 309 - 320) <http://reviews.gem5.org/r/3558/#comment7413> Indentation src/mem/ruby/network/garnet2.0/NetworkInterface.cc (line 312) <http://reviews.gem5.org/r/3558/#comment7412> Space after 'if' src/mem/ruby/network/garnet2.0/OutputUnit.cc (line 102) <http://reviews.gem5.org/r/3558/#comment7414> Opening brace src/mem/ruby/network/garnet2.0/OutputUnit.cc (line 116) <http://reviews.gem5.org/r/3558/#comment7415> Opening brace src/mem/ruby/network/garnet2.0/OutputUnit.cc (line 118) <http://reviews.gem5.org/r/3558/#comment7416> Opening brace src/mem/ruby/network/garnet2.0/Router.hh (line 105) <http://reviews.gem5.org/r/3558/#comment7417> Space before '{' src/mem/ruby/network/garnet2.0/Router.hh (line 110) <http://reviews.gem5.org/r/3558/#comment7418> Space before '{' src/mem/ruby/network/garnet2.0/Router.cc (line 91) <http://reviews.gem5.org/r/3558/#comment7419> Opening brace src/mem/ruby/network/garnet2.0/Router.cc (line 102) <http://reviews.gem5.org/r/3558/#comment7420> Opening brace src/mem/ruby/network/garnet2.0/Router.cc (line 257) <http://reviews.gem5.org/r/3558/#comment7421> Space before '{' src/mem/ruby/network/garnet2.0/RoutingUnit.cc (line 134) <http://reviews.gem5.org/r/3558/#comment7422> Opening brace src/mem/ruby/network/garnet2.0/RoutingUnit.cc (lines 147 - 148) <http://reviews.gem5.org/r/3558/#comment7423> Space after 'switch', and opening brace src/mem/ruby/network/garnet2.0/RoutingUnit.cc (lines 195 - 203) <http://reviews.gem5.org/r/3558/#comment7424> Braces src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 130) <http://reviews.gem5.org/r/3558/#comment7425> Opening brace src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 139) <http://reviews.gem5.org/r/3558/#comment7426> Opening brace src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 191) <http://reviews.gem5.org/r/3558/#comment7427> Opening brace src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 292) <http://reviews.gem5.org/r/3558/#comment7428> Opening brace src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 296) <http://reviews.gem5.org/r/3558/#comment7429> Opening brace src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (lines 303 - 305) <http://reviews.gem5.org/r/3558/#comment7430> Braces src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 316) <http://reviews.gem5.org/r/3558/#comment7431> Opening brace - Jieming Yin On July 13, 2016, 7:04 a.m., Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3558/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 7:04 a.m.) > > > Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and > Matthew Poremba. > > > Repository: gem5 > > > Description > ------- > > network: garnet2.0 > Revamped version of garnet with more optimized single-cycle routers, > more configurability, and cleaner code. > > > Diffs > ----- > > src/mem/ruby/network/garnet2.0/RoutingUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/SConscript PRE-CREATION > src/mem/ruby/network/garnet2.0/SwitchAllocator.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/SwitchAllocator.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/VirtualChannel.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/VirtualChannel.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/flit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/flit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/flitBuffer.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/flitBuffer.cc PRE-CREATION > configs/network/Network.py PRE-CREATION > configs/topologies/Crossbar.py cdb94f2332a6 > configs/topologies/MeshDirCorners_XY.py PRE-CREATION > configs/topologies/Mesh_XY.py PRE-CREATION > configs/topologies/Mesh_westfirst.py PRE-CREATION > configs/topologies/Pt2Pt.py cdb94f2332a6 > src/base/statistics.cc cdb94f2332a6 > src/mem/ruby/network/BasicRouter.py cdb94f2332a6 > src/mem/ruby/network/garnet2.0/CommonTypes.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/Credit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/Credit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/CreditLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/CrossbarSwitch.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/CrossbarSwitch.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetLink.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetLink.py PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.py PRE-CREATION > src/mem/ruby/network/garnet2.0/InputUnit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/InputUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkInterface.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkInterface.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkLink.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/OutVcState.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/OutVcState.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/OutputUnit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/OutputUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/README.txt PRE-CREATION > src/mem/ruby/network/garnet2.0/Router.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/Router.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/RoutingUnit.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/3558/diff/ > > > Testing > ------- > > > Thanks, > > Tushar Krishna > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
