-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3580/#review8551
-----------------------------------------------------------


I would really prefer if we didn't have to add this complexity.

I thought we were pretty much in a position where we could remove the horrible 
shadow memory hack. Could we not pursue that route rather? It would be a much 
better solution long term.

- Andreas Hansson


On July 26, 2016, 11:22 p.m., David Hashe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3580/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 11:22 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 11562:7375e1f533fa
> ---------------------------
> cpu, mem, sim: Enable KVM support for Ruby
> 
> Use heuristic to avoid mapping both main memory and its copy when
>  --access-backing-store is specified.
> 
> Remember whether a BackingStoreEntry is in the global address map.
> 
> Fix bug causing incomplete draining of Ruby Sequencer.
> 
> Skip mapping ranges reserved by KVM.
> 
> 
> Diffs
> -----
> 
>   src/cpu/kvm/vm.cc 704b0198f747b766b839c577614eb2924fd1dfee 
>   src/mem/physical.hh 704b0198f747b766b839c577614eb2924fd1dfee 
>   src/mem/physical.cc 704b0198f747b766b839c577614eb2924fd1dfee 
>   src/mem/ruby/system/Sequencer.cc 704b0198f747b766b839c577614eb2924fd1dfee 
>   src/sim/system.cc 704b0198f747b766b839c577614eb2924fd1dfee 
> 
> Diff: http://reviews.gem5.org/r/3580/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Hashe
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to