----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3580/#review8579 -----------------------------------------------------------
I see how this works as a stop gap, but ultimately I would like to push for the removal of the shadow memory as the first option. Is it really that much effort? src/mem/physical.hh (line 67) <http://reviews.gem5.org/r/3580/#comment7453> in the guest src/mem/physical.hh (line 72) <http://reviews.gem5.org/r/3580/#comment7454> perhaps beef this up a bit: the host memory? same size as range? src/mem/physical.hh (line 77) <http://reviews.gem5.org/r/3580/#comment7456> Again not a very descriptive parameter. src/mem/physical.hh (line 79) <http://reviews.gem5.org/r/3580/#comment7455> whitespace line src/mem/physical.cc (line 85) <http://reviews.gem5.org/r/3580/#comment7457> I find the control flow here very odd. The kvm_addr_map is initialised and set on a path different to where it is used? What memory is it affecting? Why is it sticky? What if one is not kvm mapped and the others are etc? src/mem/physical.cc (line 142) <http://reviews.gem5.org/r/3580/#comment7458> Same oddity with the configuration here. We should check each and every memory. src/mem/ruby/system/Sequencer.cc (line 254) <http://reviews.gem5.org/r/3580/#comment7459> This seems completely unrelated. - Andreas Hansson On Aug. 5, 2016, 1:39 a.m., David Hashe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3580/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2016, 1:39 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11562:7375e1f533fa > --------------------------- > cpu, mem, sim: Enable KVM support for Ruby > > Only map memories into the KVM guest address space that are > marked as usable by KVM. > > Remember whether a BackingStoreEntry should be mapped by KVM. > > Fix bug causing incomplete draining of Ruby Sequencer. > > > Diffs > ----- > > src/cpu/kvm/vm.cc 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/AbstractMemory.py 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/abstract_mem.hh 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/abstract_mem.cc 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/physical.hh 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/physical.cc 704b0198f747b766b839c577614eb2924fd1dfee > src/mem/ruby/system/Sequencer.cc 704b0198f747b766b839c577614eb2924fd1dfee > > Diff: http://reviews.gem5.org/r/3580/diff/ > > > Testing > ------- > > > Thanks, > > David Hashe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
