----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3583/#review8585 -----------------------------------------------------------
Ship it! LGTM. Two questions about testing, though. 1) Did you test the 32-bit versions? 2) Can you add tests for these? It seems like you have some small bits of code. If they only take a few seconds to run in gem5, you should make a new regression test. Thanks! - Jason Lowe-Power On Aug. 8, 2016, 9:18 a.m., Nicolas Derumigny wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3583/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 9:18 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > syscall_emul: Added getdents and getdents64 syscalls > > > Diffs > ----- > > src/arch/x86/linux/process.cc ba45735a726a > src/sim/syscall_emul.hh ba45735a726a > src/sim/syscall_emul.cc ba45735a726a > > Diff: http://reviews.gem5.org/r/3583/diff/ > > > Testing > ------- > > Works with readdir() wrapper, tested with CERE codelets > (https://github.com/benchmark-subsetting/cere). > > > Thanks, > > Nicolas Derumigny > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
