----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3583/#review8689 -----------------------------------------------------------
Ship it! Ship It! src/arch/x86/linux/process.cc (line 438) <http://reviews.gem5.org/r/3583/#comment7520> What is the reasoning behind this change? The system calls are defined by what the Linux kernel has set for them; we can't arbitrarily decide to alter the call to a different variant. src/sim/syscall_emul.hh (line 305) <http://reviews.gem5.org/r/3583/#comment7523> remove whitespace on lines 305, 307, 311, and 313 src/sim/syscall_emul.cc (line 363) <http://reviews.gem5.org/r/3583/#comment7521> space around '=' src/sim/syscall_emul.cc (line 383) <http://reviews.gem5.org/r/3583/#comment7522> space around '=' - Brandon Potter On Aug. 26, 2016, 12:10 p.m., Nicolas Derumigny wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3583/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 12:10 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > syscall_emul: Added getdents and getdents64 syscalls > > > Diffs > ----- > > src/arch/x86/linux/process.cc ba45735a726a > src/sim/syscall_emul.hh ba45735a726a > src/sim/syscall_emul.cc ba45735a726a > > Diff: http://reviews.gem5.org/r/3583/diff/ > > > Testing > ------- > > Works with readdir() wrapper, tested with CERE codelets > (https://github.com/benchmark-subsetting/cere). > > > Thanks, > > Nicolas Derumigny > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
