----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3653/#review8805 -----------------------------------------------------------
Ship it! May want to move away from _cacheLineSize per Brandon's email: http://www.mail-archive.com/gem5-dev@gem5.org/msg20380.html. I would suggest using the variable cacheLineSize and use getCacheLineSize as the getter. Though, this isn't codified in they style guideline (yet?), so I am not holding up this patch. Do whatever you think is best :). - Jason Lowe-Power On Oct. 10, 2016, 6:29 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3653/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 6:29 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11680:628dddff9aa4 > --------------------------- > gpu-compute: use System cache line size in the GPU > > > Diffs > ----- > > src/gpu-compute/compute_unit.hh 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/gpu-compute/compute_unit.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/gpu-compute/fetch_unit.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > src/gpu-compute/shader.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > > Diff: http://reviews.gem5.org/r/3653/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
