-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3665/#review8853
-----------------------------------------------------------


Thanks for submitting this! The change looks good other than a coupld of 
redundant imports.


configs/example/arm/fs_bigLITTLE.py (lines 55 - 57)
<http://reviews.gem5.org/r/3665/#comment7621>

    These two imports aren't needed.


- Andreas Sandberg


On Oct. 17, 2016, 3:19 a.m., Anastasiia Butko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3665/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 3:19 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 11670:b33e4c1cf21c
> ---------------------------
> arm, config: Enabled MemConfig usage for the example big.LITTLE
> 
> This patch replaces the SimpleMemory with the MemConfig function. Additional 
> parser arguments are added
> (TODO: improve with addCommonOptions & addFSOptions).
> 
> Reported-by: Anastasiia Butko <abu...@lbl.gov>
> 
> 
> Diffs
> -----
> 
>   configs/example/arm/fs_bigLITTLE.py 220fa4099b9a 
> 
> Diff: http://reviews.gem5.org/r/3665/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anastasiia Butko
> 
>

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to