----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3665/#review8855 -----------------------------------------------------------
Ship it! One small thing and a comment below. configs/example/arm/fs_bigLITTLE.py (line 143) <http://reviews.gem5.org/r/3665/#comment7622> There's no change needed here. However, this is a potential problem in the future. We're basically re-creating the options that are in configs/common/Option.py:addCommonOptions(). I don't think there is a simple solution to this right now, but we need to think about a fix for this in the future. configs/example/arm/fs_bigLITTLE.py (line 157) <http://reviews.gem5.org/r/3665/#comment7623> Triple quotes aren't necessary here. - Jason Lowe-Power On Oct. 17, 2016, 2:19 a.m., Anastasiia Butko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3665/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2016, 2:19 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11670:b33e4c1cf21c > --------------------------- > arm, config: Enabled MemConfig usage for the example big.LITTLE > > This patch replaces the SimpleMemory with the MemConfig function. Additional > parser arguments are added > (TODO: improve with addCommonOptions & addFSOptions). > > Reported-by: Anastasiia Butko <abu...@lbl.gov> > > > Diffs > ----- > > configs/example/arm/fs_bigLITTLE.py 220fa4099b9a > > Diff: http://reviews.gem5.org/r/3665/diff/ > > > Testing > ------- > > > Thanks, > > Anastasiia Butko > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
