----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3683/#review8958 -----------------------------------------------------------
Thanks for breaking out the configs. Seems only garnet_synth_traffic.py is modified to call Options.addBaseOptions(parser), does other testers need to be modified? configs/common/FSConfig.py (line 45) <http://reviews.gem5.org/r/3683/#comment7699> Should it be "from common import PlatformConfig" here as well, just like in Options.py? This script might cause a problem if /gem5/configs/common is not added to path. - Jieming Yin On Oct. 20, 2016, 11:07 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3683/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 11:07 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11688:60b7de6442f3 > --------------------------- > config: Break out base options for usage with NULL ISA > > This patch breaks out the most basic configuration options into a set > of base options, to allow them to be used also by scripts that do not > involve any actual CPUs or devices. The patch also fixes a few modules > so that they can be imported in a NULL build, and avoid dragging in > FSConfig every time Options is imported. > > > Diffs > ----- > > configs/common/CpuConfig.py b3d5f0e9e258 > configs/common/FSConfig.py b3d5f0e9e258 > configs/common/Options.py b3d5f0e9e258 > configs/common/PlatformConfig.py b3d5f0e9e258 > configs/example/garnet_synth_traffic.py b3d5f0e9e258 > > Diff: http://reviews.gem5.org/r/3683/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
