> On Oct. 20, 2016, 10:14 p.m., Jieming Yin wrote: > > configs/common/FSConfig.py, line 45 > > <http://reviews.gem5.org/r/3683/diff/1/?file=61965#file61965line45> > > > > Should it be "from common import PlatformConfig" here as well, just > > like in Options.py? This script might cause a problem if > > /gem5/configs/common is not added to path.
Sorted. Any further comments? Note that I also changed the name of the function adding the non-ISA options, to avoid "base" and "common" saying roughly the same thing. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3683/#review8958 ----------------------------------------------------------- On Oct. 24, 2016, 9:10 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3683/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 9:10 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11688:3b7d93ec1cf1 > --------------------------- > config: Break out base options for usage with NULL ISA > > This patch breaks out the most basic configuration options into a set > of base options, to allow them to be used also by scripts that do not > involve any ISA, and thus no actual CPUs or devices. > > The patch also fixes a few modules so that they can be imported in a > NULL build, and avoid dragging in FSConfig every time Options is > imported. > > > Diffs > ----- > > configs/common/CpuConfig.py b3d5f0e9e258 > configs/common/FSConfig.py b3d5f0e9e258 > configs/common/Options.py b3d5f0e9e258 > configs/common/PlatformConfig.py b3d5f0e9e258 > configs/common/Simulation.py b3d5f0e9e258 > configs/example/garnet_synth_traffic.py b3d5f0e9e258 > configs/example/ruby_direct_test.py b3d5f0e9e258 > configs/example/ruby_gpu_random_test.py b3d5f0e9e258 > configs/example/ruby_mem_test.py b3d5f0e9e258 > configs/example/ruby_random_test.py b3d5f0e9e258 > > Diff: http://reviews.gem5.org/r/3683/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
