----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/#review8986 -----------------------------------------------------------
src/mem/cache/tags/base_set_assoc.hh (line 233) <http://reviews.gem5.org/r/3502/#comment7716> If you don't mind changing it, could we keep the operator on the first line? The same goes for the condition in the if statement. I am not sure if this is actually captured in the style, but it is definitley convention. The same goes for the copy in FA-LRU Thanks! - Andreas Hansson On Oct. 25, 2016, 9:18 a.m., Sophiane SENNI wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3502/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 9:18 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11688:74be5cba513a > --------------------------- > mem: Split the hit_latency into tag_latency and data_latency > > If the cache access mode is parallel, i.e. "sequential_access" parameter > is set to "False", tags and data are accessed in parallel. Therefore, > the hit_latency is the maximum latency between tag_latency and > data_latency. On the other hand, if the cache access mode is > sequential, i.e. "sequential_access" parameter is set to "True", > tags and data are accessed sequentially. Therefore, the hit_latency > is the sum of tag_latency plus data_latency. > > > Diffs > ----- > > configs/common/Caches.py 4aac82f10951 > configs/common/O3_ARM_v7a.py 4aac82f10951 > configs/example/arm/devices.py 4aac82f10951 > configs/learning_gem5/part1/caches.py 4aac82f10951 > src/mem/cache/Cache.py 4aac82f10951 > src/mem/cache/base.hh 4aac82f10951 > src/mem/cache/base.cc 4aac82f10951 > src/mem/cache/tags/Tags.py 4aac82f10951 > src/mem/cache/tags/base.hh 4aac82f10951 > src/mem/cache/tags/base.cc 4aac82f10951 > src/mem/cache/tags/base_set_assoc.hh 4aac82f10951 > src/mem/cache/tags/fa_lru.hh 4aac82f10951 > src/mem/cache/tags/fa_lru.cc 4aac82f10951 > > Diff: http://reviews.gem5.org/r/3502/diff/ > > > Testing > ------- > > Tested using --Debug-flags=Cache > > > Thanks, > > Sophiane SENNI > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
