----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3528/#review8989 -----------------------------------------------------------
Some of the files are not displaying ok. Did you post the review using hg postreview? util/tlm/examples/master_port/Makefile (line 37) <http://reviews.gem5.org/r/3528/#comment7748> Same as previous patch. This should use pkt-config. util/tlm/examples/master_port/Makefile (line 40) <http://reviews.gem5.org/r/3528/#comment7749> An assignment to a name would be good for these paths. GEM5_ROOT or similar util/tlm/examples/master_port/main.cc (line 101) <http://reviews.gem5.org/r/3528/#comment7750> gem5 has a random_mt that you should preferably use util/tlm/examples/master_port/main.cc (line 187) <http://reviews.gem5.org/r/3528/#comment7751> Same as the other patch. Why not use the response string size? util/tlm/sc_master_port.hh (line 32) <http://reviews.gem5.org/r/3528/#comment7738> Not convention util/tlm/sc_master_port.hh (line 49) <http://reviews.gem5.org/r/3528/#comment7739> Could you provide a bit more comments here around what is assumed, how it does what it does, what it doesn't do, etc util/tlm/sc_master_port.cc (line 32) <http://reviews.gem5.org/r/3528/#comment7740> Same as the header util/tlm/sc_master_port.cc (line 73) <http://reviews.gem5.org/r/3528/#comment7741> Is it assumed that the request is deleted elsewhere? util/tlm/sc_master_port.cc (line 81) <http://reviews.gem5.org/r/3528/#comment7742> comma on the line before name, other name util/tlm/sc_master_port.cc (line 90) <http://reviews.gem5.org/r/3528/#comment7743> Why the re-interpret cast? util/tlm/sc_master_port.cc (line 98) <http://reviews.gem5.org/r/3528/#comment7744> it is not a big problem, but technically gem5 can change mode during the simulation. The API for this is involving calls to drain and drain resume etc. We don't have to fix it now, but it may be worth at least warning if any of these functions are called. util/tlm/sc_master_port.cc (line 116) <http://reviews.gem5.org/r/3528/#comment7745> could we base this on the response string rather to avoid buffer overflows? :-) util/tlm/sc_master_port.cc (line 126) <http://reviews.gem5.org/r/3528/#comment7746> odd indentation util/tlm/sc_master_port.cc (line 138) <http://reviews.gem5.org/r/3528/#comment7747> what is this checking? - Andreas Hansson On Oct. 26, 2016, 4:23 p.m., Christian Menard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3528/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 4:23 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > The current TLM code only provides a Slave Port that allows the gem5 world to > send requests to the the TLM world. This patch adds a Master Port that allows > the TLM world to send requests to the gem5 world. Furthermore, the patch > provides a simple example application based on a TLM traffic generator. > > > Diffs > ----- > > util/tlm/sc_master_port.cc PRE-CREATION > util/tlm/sim_control.cc c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > util/tlm/examples/master_port/Makefile PRE-CREATION > util/tlm/examples/master_port/main.cc PRE-CREATION > util/tlm/examples/master_port/tlm.py PRE-CREATION > util/tlm/examples/slave_port/Makefile > c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > util/tlm/sc_master_port.hh PRE-CREATION > util/tlm/README c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > > Diff: http://reviews.gem5.org/r/3528/diff/ > > > Testing > ------- > > A simple example application consisting of a TLM traffic generator and a gem5 > memory is part of the patch. > > > Thanks, > > Christian Menard > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
