----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3528/#review9081 -----------------------------------------------------------
Thanks for this. Some minor requests and style issues, then it's good to go. util/tlm/sc_master_port.cc (line 74) <http://reviews.gem5.org/r/3528/#comment7836> It would be good to add a comment explaining where the request is deleted. util/tlm/sc_master_port.cc (line 232) <http://reviews.gem5.org/r/3528/#comment7837> this is not a safe assumption use SimClock::Int::ps for the "conversion" util/tlm/sc_master_port.cc (line 289) <http://reviews.gem5.org/r/3528/#comment7838> do things work even if this is not TLM_UPDATED? - Andreas Hansson On Nov. 7, 2016, 2:56 p.m., Christian Menard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3528/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 2:56 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11707:cb37987f081e > --------------------------- > misc: add a TLM to Gem5 Master Port > > The current TLM code only provides a Slave Port that allows the gem5 world to > send requests to the the TLM world. This patch adds a Master Port that allows > the TLM world to send requests to the gem5 world. Furthermore, the patch > provides a simple example application based on a TLM traffic generator. > > > Diffs > ----- > > util/tlm/sc_master_port.cc PRE-CREATION > util/tlm/sim_control.cc PRE-CREATION > util/tlm/examples/master_port/traffic_generator.hh PRE-CREATION > util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION > util/tlm/sc_master_port.hh PRE-CREATION > util/tlm/README b3d5f0e9e258 > util/tlm/examples/master_port/SConstruct PRE-CREATION > util/tlm/examples/master_port/main.cc PRE-CREATION > util/tlm/examples/master_port/tlm.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3528/diff/ > > > Testing > ------- > > A simple example application consisting of a TLM traffic generator and a gem5 > memory is part of the patch. > > > Thanks, > > Christian Menard > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
