----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3711/#review9118 -----------------------------------------------------------
src/mem/ruby/network/garnet2.0/GarnetNetwork.py (line 49) <http://reviews.gem5.org/r/3711/#comment7859> what is the unit? if it is time we should not use Uint src/mem/ruby/network/garnet2.0/GarnetNetwork.py (line 62) <http://reviews.gem5.org/r/3711/#comment7858> what is the unit? src/mem/ruby/network/garnet2.0/NetworkInterface.cc (line 73) <http://reviews.gem5.org/r/3711/#comment7855> just do it in the initialisation list src/mem/ruby/network/garnet2.0/NetworkInterface.cc (line 326) <http://reviews.gem5.org/r/3711/#comment7856> this should not be a panic, perhaps a fatal? src/mem/ruby/network/garnet2.0/NetworkInterface.cc (line 328) <http://reviews.gem5.org/r/3711/#comment7857> seems the arguments are wrong? curTick should also be llu if I remember correctly - Andreas Hansson On Nov. 17, 2016, 6:37 p.m., Jieming Yin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3711/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 6:37 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11706:527f77b1d6df > --------------------------- > ruby: Detect garnet network-level deadlock. > > This patch detects garnet network deadlock by monitoring > network interfaces. If a network interface continuously > fails to allocate virtual channels for a message, a > possible deadlock is detected. > > > Diffs > ----- > > configs/network/Network.py c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/mem/ruby/network/garnet2.0/GarnetNetwork.py > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/mem/ruby/network/garnet2.0/NetworkInterface.hh > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/mem/ruby/network/garnet2.0/NetworkInterface.cc > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3711/diff/ > > > Testing > ------- > > > Thanks, > > Jieming Yin > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
