> On Nov. 17, 2016, 10:36 p.m., Andreas Hansson wrote: > > src/mem/ruby/network/garnet2.0/NetworkInterface.cc, line 326 > > <http://reviews.gem5.org/r/3711/diff/2/?file=63632#file63632line326> > > > > this should not be a panic, perhaps a fatal? > > Jieming Yin wrote: > I think here should be a panic, since it's not an error caused by user. > If the condition satisfies, it is very likely to be a garnet routing problem.
Usually panic is for issues caused by a bug/error in the simulator itself. As you say, fatal is configuration/user related. In this case I guess its somewhere in between. It is a bug in a protocol, not the simulator itself. I'm fine with either. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3711/#review9118 ----------------------------------------------------------- On Dec. 1, 2016, 11:37 p.m., Jieming Yin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3711/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2016, 11:37 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11706:c2eb8893beb5 > --------------------------- > ruby: Detect garnet network-level deadlock. > > This patch detects garnet network deadlock by monitoring > network interfaces. If a network interface continuously > fails to allocate virtual channels for a message, a > possible deadlock is detected. > > > Diffs > ----- > > src/mem/ruby/network/garnet2.0/NetworkInterface.hh > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/mem/ruby/network/garnet2.0/NetworkInterface.cc > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > configs/network/Network.py c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/mem/ruby/network/garnet2.0/GarnetNetwork.py > c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3711/diff/ > > > Testing > ------- > > > Thanks, > > Jieming Yin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
