----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9209 -----------------------------------------------------------
src/cpu/pred/ltage.hh (line 379) <http://reviews.gem5.org/r/3743/#comment7915> Why not use a vector<bool>? This is what it's actually representing, correct? I would argue for using the datatype that makes it most clear to future people reading this code. - Jason Lowe-Power On Nov. 23, 2016, 2:52 p.m., Arthur Perais wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3743/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 2:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11707:1d085f66c4ca > --------------------------- > > cpu: implement an L-TAGE branch predictor > > This patch implements an L-TAGE predictor, based on André Seznec's code > available from > CBP-2 > (http://hpca23.cse.tamu.edu/taco/camino/cbp2/cbp-src/realistic-seznec.h). The > patch also changes the default branch predictor of o3 from the tournament > predictor > to L-TAGE. > > This patch requires patch #3727 (http://reviews.gem5.org/r/3727/) to compile. > > > Diffs > ----- > > src/cpu/pred/BranchPredictor.py 1d085f66c4ca > src/cpu/pred/SConscript 1d085f66c4ca > src/cpu/pred/ltage.hh PRE-CREATION > src/cpu/pred/ltage.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3743/diff/ > > > Testing > ------- > > > Thanks, > > Arthur Perais > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
