> On déc. 15, 2016, 7:47 après-midi, Jason Lowe-Power wrote: > > src/cpu/pred/ltage.hh, line 379 > > <http://reviews.gem5.org/r/3743/diff/2/?file=63761#file63761line379> > > > > Why not use a vector<bool>? This is what it's actually representing, > > correct? > > > > I would argue for using the datatype that makes it most clear to future > > people reading this code.
This is true, but unfortunately I really don't have time to refactor right now. I will leave a comment in the code (e.g., TODO) for future reference. - Arthur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9209 ----------------------------------------------------------- On nov. 23, 2016, 2:52 après-midi, Arthur Perais wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3743/ > ----------------------------------------------------------- > > (Updated nov. 23, 2016, 2:52 après-midi) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11707:1d085f66c4ca > --------------------------- > > cpu: implement an L-TAGE branch predictor > > This patch implements an L-TAGE predictor, based on André Seznec's code > available from > CBP-2 > (http://hpca23.cse.tamu.edu/taco/camino/cbp2/cbp-src/realistic-seznec.h). The > patch also changes the default branch predictor of o3 from the tournament > predictor > to L-TAGE. > > This patch requires patch #3727 (http://reviews.gem5.org/r/3727/) to compile. > > > Diffs > ----- > > src/cpu/pred/BranchPredictor.py 1d085f66c4ca > src/cpu/pred/SConscript 1d085f66c4ca > src/cpu/pred/ltage.hh PRE-CREATION > src/cpu/pred/ltage.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3743/diff/ > > > Testing > ------- > > > Thanks, > > Arthur Perais > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
