> On Jan. 19, 2017, 10:28 p.m., Jason Lowe-Power wrote: > > Seems OK to me. Don't let anyone ever tell you that C++ makes reading code > > easy... I appreciate all of the compile-time tricks going on here, but it > > is incredibly difficult to read. > > > > Maybe some more comments for each class that have an example on how to use > > it would be helpful? I'm a little concerned what's going to happen to this > > code in 5 years. Will a new person be able to come in and understand what's > > going on? Though, it isn't like any of this ISA code is understandable > > until you put weeks or months of effort in. So, feel free to ignore this > > comment.
I will make sure the documentation is more comprehensive. Thanks for taking the time! - Rekai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3757/#review9286 ----------------------------------------------------------- On Jan. 16, 2017, 11:54 a.m., Rekai Gonzalez Alberquilla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3757/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 11:54 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11762:8b0fdbea39bf > --------------------------- > arch: added generic vector register > > This commit adds a new generic vector register to have a cleaner > implementation of SIMD ISAs. > > Nathanael's idea, Rekai's implementation. > > Change-Id: I60b250bba6423153b7e04d2e6988d517a70a3e6b > Reviewed-by: Andreas Sandberg <[email protected]> > > > Diffs > ----- > > src/arch/generic/vec_reg.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/3757/diff/ > > > Testing > ------- > > Builtin regressions > > > Thanks, > > Rekai Gonzalez Alberquilla > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
