> On Jan. 18, 2017, 4:02 p.m., Jason Lowe-Power wrote: > > Is there any way you can remove the #if USE_KVM from the system.cc file? I > > don't have any suggestions off the top of my head, though.
We agree that it's not the best, but we didn't see a better solution to this problem. We are willing to entertain suggestions, though. - Curtis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9259 ----------------------------------------------------------- On Jan. 17, 2017, 10:04 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3785/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 10:04 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > sim, kvm: make KvmVM a System parameter > > A KVM VM is typically a child of the System object already, but for > solving future issues with configuration graph resolution, the most > logical way to keep track of this object is for it to be an actual > parameter of the System object. > > Change-Id: I965ded22203ff8667db9ca02de0042ff1c772220 > Reviewed-by: Andreas Sandberg <[email protected]> > > > Diffs > ----- > > src/arch/arm/kvm/KvmGic.py 97eebddaae84 > src/arch/arm/kvm/gic.cc 97eebddaae84 > src/cpu/kvm/BaseKvmCPU.py 97eebddaae84 > src/cpu/kvm/KvmVM.py 97eebddaae84 > src/cpu/kvm/base.cc 97eebddaae84 > src/cpu/kvm/vm.hh 97eebddaae84 > src/cpu/kvm/vm.cc 97eebddaae84 > src/sim/System.py 97eebddaae84 > src/sim/system.hh 97eebddaae84 > src/sim/system.cc 97eebddaae84 > configs/example/fs.py 97eebddaae84 > configs/example/se.py 97eebddaae84 > > Diff: http://reviews.gem5.org/r/3785/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
