> On Jan. 26, 2017, 5:21 p.m., Alexandru Dutu wrote:
> > src/sim/system.cc, line 98
> > <http://reviews.gem5.org/r/3785/diff/1/?file=64713#file64713line98>
> >
> > It seems we don't need #if here, p->kvm_vm will be nullptr in case
> > there is no initialization from python. Right?
System.py's kvm_vm parameter is conditional upon USE_KVM in the build
environment, which is the same thing that conditionally adds all the KVM things
to the build. So in case KVM is not present, the KVM SimObject won't be a
parameter of the System SimObject (error: 'System::Params {aka struct
SystemParams' has no member named 'kvm_vm').
- Curtis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3785/#review9323
-----------------------------------------------------------
On Jan. 17, 2017, 10:04 p.m., Curtis Dunham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3785/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 10:04 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> sim, kvm: make KvmVM a System parameter
>
> A KVM VM is typically a child of the System object already, but for
> solving future issues with configuration graph resolution, the most
> logical way to keep track of this object is for it to be an actual
> parameter of the System object.
>
> Change-Id: I965ded22203ff8667db9ca02de0042ff1c772220
> Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
>
>
> Diffs
> -----
>
> src/arch/arm/kvm/KvmGic.py 97eebddaae84
> src/arch/arm/kvm/gic.cc 97eebddaae84
> src/cpu/kvm/BaseKvmCPU.py 97eebddaae84
> src/cpu/kvm/KvmVM.py 97eebddaae84
> src/cpu/kvm/base.cc 97eebddaae84
> src/cpu/kvm/vm.hh 97eebddaae84
> src/cpu/kvm/vm.cc 97eebddaae84
> src/sim/System.py 97eebddaae84
> src/sim/system.hh 97eebddaae84
> src/sim/system.cc 97eebddaae84
> configs/example/fs.py 97eebddaae84
> configs/example/se.py 97eebddaae84
>
> Diff: http://reviews.gem5.org/r/3785/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Curtis Dunham
>
>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
